libtabula

Check-in [01622c2244]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Added a FIXME comment
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:01622c22448bfd310aa64d8202221596361902c2
User & Date: tangent 2015-12-21 02:10:16
Context
2016-02-06
10:02
Added a missing library check-in: 9e56dd977c user: tangent tags: trunk
2015-12-21
02:10
Added a FIXME comment check-in: 01622c2244 user: tangent tags: trunk
2015-12-18
23:29
Copying the refcounted pointer to the FieldNames object in Row::operator =() instead of copying the field names. We can share the object. check-in: 1e03cb233c user: tangent tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/mysql/driver.cpp.

141
142
143
144
145
146
147




148
149
150
151
152
153
154
	mysql_field_seek(pres, 0);	// semantics break otherwise!
}


Row
MySQLDriver::fetch_row(ResultBase& res)
{




	if (MYSQL_ROW raw = mysql_fetch_row(MYSQL_RES_FROM_IMPL(res.impl()))) {
		Row::size_type size = res.num_fields();
		Row::Impl* pd = new Row::Impl;
		pd->reserve(size);
		const unsigned long* lengths = fetch_lengths(res.impl());
		for (Row::size_type i = 0; i < size; ++i) {
			bool is_null = raw[i] == 0;







>
>
>
>







141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
	mysql_field_seek(pres, 0);	// semantics break otherwise!
}


Row
MySQLDriver::fetch_row(ResultBase& res)
{
	// FIXME: Why is this called after Query.store()?   It should only
	// happen after Query.use() because the table data is in the
	// StoreQueryResult object.  This is what crashes the count_rows()
	// call in examples/resetdb.cpp.
	if (MYSQL_ROW raw = mysql_fetch_row(MYSQL_RES_FROM_IMPL(res.impl()))) {
		Row::size_type size = res.num_fields();
		Row::Impl* pd = new Row::Impl;
		pd->reserve(size);
		const unsigned long* lengths = fetch_lengths(res.impl());
		for (Row::size_type i = 0; i < size; ++i) {
			bool is_null = raw[i] == 0;